Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JDK 17 #524

Closed
apupier opened this issue Nov 2, 2022 · 13 comments
Closed

Support JDK 17 #524

apupier opened this issue Nov 2, 2022 · 13 comments

Comments

@apupier
Copy link
Member

apupier commented Nov 2, 2022

JDK 17 is the latest LTS (Lon-term Support) released as of today.
it would be nice to support it
@rhuss
Copy link
Member

rhuss commented Nov 19, 2022

Definitely a +1 from my side.

@varikin
Copy link

varikin commented Jun 15, 2023

I am rolling out JDK 17 and tested our current version, Jolokia 1.6.2. Basic functionality is working of getting JMX over HTTP as JSON. Is there more that I should be testing related to 17 and Jolokia?

@grgrzybek
Copy link
Contributor

Tests work on JDK 1.7:

[INFO] Reactor Summary:
[INFO] 
[INFO] jolokia-parent ..................................... SUCCESS [  0.191 s]
[INFO] jolokia-test-util .................................. SUCCESS [  1.211 s]
[INFO] jolokia-agent-parent ............................... SUCCESS [  0.005 s]
[INFO] jolokia-core ....................................... SUCCESS [ 20.601 s]
[INFO] jolokia-jsr160 ..................................... SUCCESS [  1.192 s]
[INFO] jolokia-war ........................................ SUCCESS [  0.390 s]
[INFO] jolokia-war-unsecured .............................. SUCCESS [  0.055 s]
[INFO] jolokia-osgi ....................................... SUCCESS [  3.577 s]
[INFO] jolokia-osgi-bundle ................................ SUCCESS [  1.293 s]
[INFO] jolokia-jmx ........................................ SUCCESS [  2.142 s]
[INFO] jolokia-jvm ........................................ SUCCESS [ 28.112 s]
[INFO] jolokia-spring ..................................... SUCCESS [  6.042 s]
[INFO] jolokia-mule ....................................... SUCCESS [  2.434 s]
[INFO] jolokia-it-parent .................................. SUCCESS [  0.004 s]
[INFO] jolokia-it-core .................................... SUCCESS [  0.345 s]
[INFO] jolokia-it-war ..................................... SUCCESS [  0.076 s]
[INFO] jolokia-client-parent .............................. SUCCESS [  0.004 s]
[INFO] jolokia-client-java ................................ SUCCESS [  8.701 s]
[INFO] jolokia-client-javascript .......................... SUCCESS [  0.349 s]
[INFO] jolokia-jmx-adapter ................................ SUCCESS [ 38.016 s]
[INFO] jolokia-kubernetes ................................. SUCCESS [  6.582 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:02 min
[INFO] Finished at: 2023-06-29T13:25:07+02:00
[INFO] Final Memory: 97M/591M
[INFO] ------------------------------------------------------------------------

$ java -version
java version "1.7.0_80"
Java(TM) SE Runtime Environment (build 1.7.0_80-b15)
Java HotSpot(TM) 64-Bit Server VM (build 24.80-b11, mixed mode)

$ mvn --version
Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T22:58:10+02:00)
Maven home: /data/java/tools/apache-maven-3.2.3
Java version: 1.7.0_80, vendor: Oracle Corporation
Java home: /data/java/javase/jdk1.7.0_80/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.3.8-200.fc38.x86_64", arch: "amd64", family: "unix"

On JDK 17:

[INFO] Reactor Summary for jolokia-parent 1.7.3-SNAPSHOT:
[INFO] 
[INFO] jolokia-parent ..................................... SUCCESS [  0.198 s]
[INFO] jolokia-test-util .................................. SUCCESS [  1.242 s]
[INFO] jolokia-agent-parent ............................... SUCCESS [  0.005 s]
[INFO] jolokia-core ....................................... SUCCESS [ 18.823 s]
[INFO] jolokia-jsr160 ..................................... SUCCESS [  1.161 s]
[INFO] jolokia-war ........................................ SUCCESS [  0.285 s]
[INFO] jolokia-war-unsecured .............................. SUCCESS [  0.047 s]
[INFO] jolokia-osgi ....................................... SUCCESS [  2.679 s]
[INFO] jolokia-osgi-bundle ................................ SUCCESS [  0.860 s]
[INFO] jolokia-jmx ........................................ SUCCESS [  1.616 s]
[INFO] jolokia-jvm ........................................ SUCCESS [ 25.068 s]
[INFO] jolokia-spring ..................................... SUCCESS [  5.633 s]
[INFO] jolokia-mule ....................................... SUCCESS [  1.983 s]
[INFO] jolokia-it-parent .................................. SUCCESS [  0.004 s]
[INFO] jolokia-it-core .................................... SUCCESS [  0.253 s]
[INFO] jolokia-it-war ..................................... SUCCESS [  0.066 s]
[INFO] jolokia-client-parent .............................. SUCCESS [  0.004 s]
[INFO] jolokia-client-java ................................ SUCCESS [  7.328 s]
[INFO] jolokia-client-javascript .......................... SUCCESS [  0.222 s]
[INFO] jolokia-jmx-adapter ................................ SUCCESS [ 44.931 s]
[INFO] jolokia-kubernetes ................................. SUCCESS [  4.900 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:58 min
[INFO] Finished at: 2023-06-29T13:27:17+02:00
[INFO] ------------------------------------------------------------------------

$ java -version
java version "17.0.7" 2023-04-18 LTS
Java(TM) SE Runtime Environment (build 17.0.7+8-LTS-224)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.7+8-LTS-224, mixed mode, sharing)

$ mvn --version
Apache Maven 3.9.3 (21122926829f1ead511c958d89bd2f672198ae9f)
Maven home: /data/java/tools/apache-maven-3.9.3
Java version: 17.0.7, vendor: Oracle Corporation, runtime: /data/java/javase/jdk-17.0.7
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.3.8-200.fc38.x86_64", arch: "amd64", family: "unix"

and on JDK 8:

[INFO] Reactor Summary for jolokia-parent 1.7.3-SNAPSHOT:
[INFO] 
[INFO] jolokia-parent ..................................... SUCCESS [  0.189 s]
[INFO] jolokia-test-util .................................. SUCCESS [  1.067 s]
[INFO] jolokia-agent-parent ............................... SUCCESS [  0.006 s]
[INFO] jolokia-core ....................................... SUCCESS [ 17.729 s]
[INFO] jolokia-jsr160 ..................................... SUCCESS [  0.967 s]
[INFO] jolokia-war ........................................ SUCCESS [  0.350 s]
[INFO] jolokia-war-unsecured .............................. SUCCESS [  0.044 s]
[INFO] jolokia-osgi ....................................... SUCCESS [  2.404 s]
[INFO] jolokia-osgi-bundle ................................ SUCCESS [  0.826 s]
[INFO] jolokia-jmx ........................................ SUCCESS [  1.487 s]
[INFO] jolokia-jvm ........................................ SUCCESS [ 24.401 s]
[INFO] jolokia-spring ..................................... SUCCESS [  5.551 s]
[INFO] jolokia-mule ....................................... SUCCESS [  1.900 s]
[INFO] jolokia-it-parent .................................. SUCCESS [  0.003 s]
[INFO] jolokia-it-core .................................... SUCCESS [  0.223 s]
[INFO] jolokia-it-war ..................................... SUCCESS [  0.066 s]
[INFO] jolokia-client-parent .............................. SUCCESS [  0.004 s]
[INFO] jolokia-client-java ................................ SUCCESS [  7.323 s]
[INFO] jolokia-client-javascript .......................... SUCCESS [  0.240 s]
[INFO] jolokia-jmx-adapter ................................ SUCCESS [ 39.892 s]
[INFO] jolokia-kubernetes ................................. SUCCESS [  4.889 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:50 min
[INFO] Finished at: 2023-06-29T13:29:43+02:00
[INFO] ------------------------------------------------------------------------

$ java -version
openjdk version "1.8.0_372"
OpenJDK Runtime Environment (build 1.8.0_372-b07)
OpenJDK 64-Bit Server VM (build 25.372-b07, mixed mode)

$ mvn --version
Apache Maven 3.9.3 (21122926829f1ead511c958d89bd2f672198ae9f)
Maven home: /data/java/tools/apache-maven-3.9.3
Java version: 1.8.0_372, vendor: everfree, runtime: /data/java/javase/jdk-8u372/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.3.8-200.fc38.x86_64", arch: "amd64", family: "unix"

@apupier
Copy link
Member Author

apupier commented Jun 29, 2023

Note: some tests related to Certificates were deactivated 174317b

@apupier
Copy link
Member Author

apupier commented Jun 29, 2023

Note: some tests related to Certificates were deactivated 174317b #523

@grgrzybek
Copy link
Contributor

grgrzybek commented Jun 29, 2023 •
edited
Loading

Works even on JDK 1.6 (after removing jolokia-kubernetes module which needs JDK 1.7+ and ignoring few tests):

[INFO] Reactor Summary:
[INFO] 
[INFO] jolokia-parent ..................................... SUCCESS [  0.193 s]
[INFO] jolokia-test-util .................................. SUCCESS [  1.499 s]
[INFO] jolokia-agent-parent ............................... SUCCESS [  0.006 s]
[INFO] jolokia-core ....................................... SUCCESS [ 21.865 s]
[INFO] jolokia-jsr160 ..................................... SUCCESS [  1.099 s]
[INFO] jolokia-war ........................................ SUCCESS [  0.469 s]
[INFO] jolokia-war-unsecured .............................. SUCCESS [  0.084 s]
[INFO] jolokia-osgi ....................................... SUCCESS [  3.296 s]
[INFO] jolokia-osgi-bundle ................................ SUCCESS [  8.009 s]
[INFO] jolokia-jmx ........................................ SUCCESS [  1.354 s]
[INFO] jolokia-jvm ........................................ SUCCESS [ 26.321 s]
[INFO] jolokia-spring ..................................... SUCCESS [  6.141 s]
[INFO] jolokia-it-parent .................................. SUCCESS [  0.004 s]
[INFO] jolokia-it-core .................................... SUCCESS [  0.265 s]
[INFO] jolokia-it-war ..................................... SUCCESS [  0.109 s]
[INFO] jolokia-client-parent .............................. SUCCESS [  0.005 s]
[INFO] jolokia-client-java ................................ SUCCESS [  8.316 s]
[INFO] jolokia-client-javascript .......................... SUCCESS [  0.358 s]
[INFO] jolokia-jmx-adapter ................................ SUCCESS [ 27.996 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:48 min
[INFO] Finished at: 2023-06-29T14:52:54+02:00
[INFO] Final Memory: 39M/421M
[INFO] ------------------------------------------------------------------------

$ java -version
java version "1.6.0_45"
Java(TM) SE Runtime Environment (build 1.6.0_45-b06)
Java HotSpot(TM) 64-Bit Server VM (build 20.45-b01, mixed mode)

$ mvn --version
Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T22:58:10+02:00)
Maven home: /data/java/tools/apache-maven-3.2.3
Java version: 1.6.0_45, vendor: Sun Microsystems Inc.
Java home: /data/java/javase/jdk1.6.0_45/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.3.8-200.fc38.x86_64", arch: "amd64", family: "unix"

@grgrzybek
Copy link
Contributor

For completeness, JDK 11:

[INFO] Reactor Summary for jolokia-parent 1.7.3-SNAPSHOT:
[INFO] 
[INFO] jolokia-parent ..................................... SUCCESS [  0.188 s]
[INFO] jolokia-test-util .................................. SUCCESS [  1.243 s]
[INFO] jolokia-agent-parent ............................... SUCCESS [  0.006 s]
[INFO] jolokia-core ....................................... SUCCESS [ 18.677 s]
[INFO] jolokia-jsr160 ..................................... SUCCESS [  1.348 s]
[INFO] jolokia-war ........................................ SUCCESS [  0.278 s]
[INFO] jolokia-war-unsecured .............................. SUCCESS [  0.048 s]
[INFO] jolokia-osgi ....................................... SUCCESS [  2.821 s]
[INFO] jolokia-osgi-bundle ................................ SUCCESS [  0.899 s]
[INFO] jolokia-jmx ........................................ SUCCESS [  1.832 s]
[INFO] jolokia-jvm ........................................ SUCCESS [ 28.255 s]
[INFO] jolokia-spring ..................................... SUCCESS [  5.904 s]
[INFO] jolokia-mule ....................................... SUCCESS [  2.185 s]
[INFO] jolokia-it-parent .................................. SUCCESS [  0.004 s]
[INFO] jolokia-it-core .................................... SUCCESS [  0.285 s]
[INFO] jolokia-it-war ..................................... SUCCESS [  0.063 s]
[INFO] jolokia-client-parent .............................. SUCCESS [  0.004 s]
[INFO] jolokia-client-java ................................ SUCCESS [  7.841 s]
[INFO] jolokia-client-javascript .......................... SUCCESS [  0.231 s]
[INFO] jolokia-jmx-adapter ................................ SUCCESS [ 43.562 s]
[INFO] jolokia-kubernetes ................................. SUCCESS [  5.072 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:01 min
[INFO] Finished at: 2023-06-29T15:13:52+02:00
[INFO] ------------------------------------------------------------------------

$ java -version
java version "11.0.19" 2023-04-18 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.19+9-LTS-224)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.19+9-LTS-224, mixed mode)

$ mvn --version
Apache Maven 3.9.3 (21122926829f1ead511c958d89bd2f672198ae9f)
Maven home: /data/java/tools/apache-maven-3.9.3
Java version: 11.0.19, vendor: Oracle Corporation, runtime: /data/java/javase/jdk-11.0.19
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "6.3.8-200.fc38.x86_64", arch: "amd64", family: "unix"

grgrzybek added a commit that referenced this issue Jun 29, 2023
@grgrzybek
[#524] Tests pass on JDK 1.6, 1.7, 8, 11 and 17
ff4f020
@grgrzybek grgrzybek mentioned this issue Jun 29, 2023
Merged
@grgrzybek
Copy link
Contributor

thanks @apupier for info - I didn't know it.
BTW I have some interesting FIPS-related scenarios which cause problems with some algorithms. I'm working on it.

@grgrzybek
Copy link
Contributor

@apupier @tadayosi @rhuss @varikin I don't think anything more has to be done here.

@tadayosi
Copy link
Member

@grgrzybek I agree. If I could add one more, I noticed that the CI doesn't assert support for 17 yet.
https://github.com/jolokia/jolokia/blob/master/.github/workflows/ci.yaml#L17
If we want to clarify we support the specific versions, maybe it's better to add all of them to the workflow.

@grgrzybek
Copy link
Contributor

I know very little about the workflows, so feel free to change it ;)

@tadayosi
Copy link
Member

I will. Just a moment please.

tadayosi added a commit to tadayosi/jolokia that referenced this issue Jun 30, 2023
@tadayosi
chore(ci): add Java 17 to CI matrix jolokia#524
037e7ee
@tadayosi tadayosi mentioned this issue Jun 30, 2023
Merged
tadayosi added a commit that referenced this issue Jul 1, 2023
@tadayosi
Merge pull request #548 from tadayosi/524-ci-add-java17
689d3b8 
chore(ci): add Java 17 to CI matrix #524
@tadayosi
Copy link
Member

tadayosi commented Jul 3, 2023

Let's close. Fixed with #547.

@tadayosi tadayosi closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@varikin @rhuss @tadayosi @grgrzybek @apupier