New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Expires:" Header should be set to the request date #71

Closed
rhuss opened this Issue Feb 27, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@rhuss
Owner

rhuss commented Feb 27, 2013

Currently we set the expires header to '-1' which, according to RFC 2616 is a possible way to mark content as stale;

HTTP/1.1 clients and caches MUST treat other invalid date formats,
especially including the value "0", as in the past (i.e., "already
expired").

To mark a response as "already expired," an origin server sends an
Expires date that is equal to the Date header value. (See the rules
for expiration calculations in section 13.2.4.)

This works for most clients, however Spring Rest Support seems to have a problem with this. So we should probably switch to the recommendation to set the Expire-Header to the Date of the request (or, if this value is not easily available at the place where the response is generated, at least to "0").

rhuss added a commit that referenced this issue Mar 17, 2013

Set explicite HTTP "Date:" and "Expire:" Header with the same value.
According to RFC-2616 this is the recommended way for signaling that
the content should not be cached. This works for the Servlet and JVM
Agent.

Also added a corresponding integration test to Jmx4Perl.

Fixes #71.
@rhuss

This comment has been minimized.

Owner

rhuss commented Mar 17, 2013

Fixed now, setting Date: and Expires: to the same value for the AgentServlet and JVM HttpHandler.

@rhuss rhuss closed this Mar 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment