Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the Mule ESB 3.5. #165

Closed

Conversation

@ogis-nakagawa
Copy link
Contributor

@ogis-nakagawa ogis-nakagawa commented Oct 18, 2014

Changed to Jetty8 from Mule ESB 3.5.
Fixing Issue #148.

@rhuss
Copy link
Owner

@rhuss rhuss commented Oct 20, 2014

Looks good to me, thanks a lot !

I assume that you contribution is released under the APL (as stated in some comments). Is this ok for you ? If so, I will merge in the PR ASAP.

@rhuss
Copy link
Owner

@rhuss rhuss commented Oct 20, 2014

Is this 'HelloWorldServlet' required for EclipseMulaAgentHttpServer ? (and why does it create a session ?)

@rhuss
Copy link
Owner

@rhuss rhuss commented Oct 20, 2014

BTW, I'm going to start to ask for signing off PRs (with git -s) in the future to confirm that contributions are open source, too (sorry, I'm not a lawyer, but I guess this might get important). If the term http://developercertificate.org/ are ok, please let me know.

Have to update my documentation yet, though.

@ogis-nakagawa
Copy link
Contributor Author

@ogis-nakagawa ogis-nakagawa commented Oct 21, 2014

Hi, thank you for code reviews.
I will accept the APL and 'http://developercertificate.org/'.

sorry, 'HelloServlet' is my mistake. Please give me some time.

@ogis-nakagawa
Copy link
Contributor Author

@ogis-nakagawa ogis-nakagawa commented Oct 23, 2014

I'm ready. Please, check the commit.

@rhuss rhuss added this to the 1.3.0 milestone Nov 8, 2014
@rhuss
Copy link
Owner

@rhuss rhuss commented Nov 8, 2014

Thanks a lot I added your contribution and will release a version 1.3.0 this weekend (hopefully ;-)

@rhuss rhuss closed this Nov 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants