Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade httpclient-osgi 4.3.3 -> 4.3.6 #323

Merged
merged 3 commits into from Sep 16, 2017
Merged

Conversation

@pgier
Copy link
Contributor

@pgier pgier commented Apr 25, 2017

Note, starting in 4.3.6, the httpcore classes are no longer bundled
with httpclient-osgi, so a separate dependency declaration is required.
See https://issues.apache.org/jira/browse/HTTPCLIENT-1558

@rhuss
Copy link
Owner

@rhuss rhuss commented Apr 26, 2017

Thanks for the heads up. Strange to see such a breaking change in a patch level version of httpclient, though.

will hopefully have time to review and intergrate this PR soon.

Thanks !

@pgier
Copy link
Contributor Author

@pgier pgier commented Apr 26, 2017

Yeah, I was surprised to see that change in 4.3.6 as well. Another way this upgrade could be done is to remove the transitive dep exclusions from httpclient-osgi, and then httpcore should be picked up transitively instead of requiring the direct dep on httpcore.

Paul Gier and others added 3 commits Apr 25, 2017
Note, starting in 4.3.6, the httpcore classes are no longer bundled
with httpclient-osgi, so a separate dependency declaration is required.
See https://issues.apache.org/jira/browse/HTTPCLIENT-1558
@rhuss rhuss force-pushed the pgier:httpcomponents-upgrade branch from 4cc6fb2 to d053569 Sep 16, 2017
@rhuss
Copy link
Owner

@rhuss rhuss commented Sep 16, 2017

thanks again, and sorry for the long delay !

@rhuss rhuss merged commit 0a6365b into rhuss:master Sep 16, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants