Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug HistoryEntry.trim when the list of values is empty and max duration is > 0 #67

Merged
merged 1 commit into from Feb 22, 2013

Conversation

@mjr5749
Copy link
Contributor

@mjr5749 mjr5749 commented Feb 20, 2013

This was throwing an exception when trying to access the first element of an empty list. Includes a test case to verify the fix. Also adds additional argument checking to the HistoryLimit constructor to prevent similar defects.

…duration is > 0 this would fail trying to access the first element of an empty list. Includes a test case to verify the fix. Also adds additional argument checking to the HistoryLimit constructor to prevent similar defects.
rhuss added a commit that referenced this issue Feb 22, 2013
Fix a bug HistoryEntry.trim when the list of values is empty and max duration is > 0
@rhuss rhuss merged commit 19c2eb0 into rhuss:master Feb 22, 2013
1 check passed
Loading
@rhuss
Copy link
Owner

@rhuss rhuss commented Feb 22, 2013

Thanks for spotting this. I will be included in the next version 1.1.0.

I assume, that your patch is licensed under the APL as well ? (sorry, 'have to ask ;-)

Loading

@mjr5749
Copy link
Contributor Author

@mjr5749 mjr5749 commented Feb 25, 2013

Yes, APL license is fine for this patch. Thanks for merging!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants