Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JolokiaServer to select its port dynamically #82

Closed
wants to merge 1 commit into from

Conversation

@benson-basis
Copy link

@benson-basis benson-basis commented Mar 3, 2013

With this patch, the server can be initialized with port=0. The HttpServer will pick a port, the JolokiaServer will retrieve the selected port, and store it in the URL.

The patch also exposes the HttpServer 'getAddress()' method and an config class to which the user can supply a map instead of a string to parse.

ability to configure server without string parsing.
@rhuss
Copy link
Owner

@rhuss rhuss commented Mar 4, 2013

Looks good, I will add your pull request this week (still need to update the docu).

Thanks a lot ...

BTW, I assume that your contribution can be licensed under the APL (as the rest of Jolokia). 'hope this is ok ...

@benson-basis
Copy link
Author

@benson-basis benson-basis commented Mar 4, 2013

certainly. I put the al notice on the new file, for example. Thanks!

On Mar 4, 2013, at 3:31 PM, "Roland Huß" notifications@github.com wrote:

Looks good, I will add your pull request this week (still need to update
the docu).

Thanks a lot ...

BTW, I assume that your contribution can be licensed under the APL (as the
rest of Jolokia). 'hope this is ok ...


Reply to this email directly or view it on
GitHubhttps://github.com//pull/82#issuecomment-14403493
.

@benson-basis
Copy link
Author

@benson-basis benson-basis commented Mar 9, 2013

ping?

@rhuss
Copy link
Owner

@rhuss rhuss commented Mar 10, 2013

Sorry, still quite busy 😦 I will try to add it this evening. It's not forgotten.

@rhuss
Copy link
Owner

@rhuss rhuss commented Mar 15, 2013

Merged in the changes.

@rhuss rhuss closed this Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants