-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Neovim from source when Nightly build fails #9
Comments
Just a note that there is similar issue with Windows now. https://github.com/kristijanhusak/vim-dadbod-ui/runs/1588245067?check_suite_focus=true |
Yes. Neovim omitted Windows build from nightly though I don't know it is intended or accidental. So there is no nightly Windows asset in the release. https://github.com/neovim/neovim/releases/tag/nightly EDIT: This was fixed. They were moving their CI from Appveyor to GitHub Actions. |
This feature is quite necessary. Just note that neovim's nightly build was broken today, the action removed the nightly tag but failed to create a new one. neovim/neovim#13732 |
May I ask: if I want to test on neovim stable and nightly build and vim nightly build only, how could I write the yml for? |
Hi @voldikss, I'm doubtful about this feature being useful actually. When nightly build is broken, it means that Neovim can't be built at the moment. If this action falls back to building Neovim from source, the build would fail. The feature is useful only when (1) nightly build failed && (2) the build was fixed by someone && (3) next nightly build is not triggered yet.
My recommendation is using strategy:
matrix:
neovim: [true, false]
version: [nightly, stable]
exclude:
- neovim: false
version: stable |
Right, I agree with you. Build from souce seems more a unnecessary duplication of neovim's own build.
Thank you for the reply! |
This was solved by #18. Closing. |
Problem
action-setup-vim fails when Nightly Neovim release is broken. Example of job failure:
https://github.com/rhysd/action-setup-vim/runs/1313461451?check_suite_focus=true
It failed because Nightly Neovim release did not provide macOS package due to failure of Neovim CI.
Solution
To solve the issue, I think providing fallback would be better. When downloading asset fails, this action can build the latest Neovim from source.
Related to #7
The text was updated successfully, but these errors were encountered: