Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preactjs/compressed-size-action@v2 is new #422

Conversation

ne-sachirou
Copy link

preactjs/compressed-size-action@v2 was old to points 2.5.0. Now it's new to points 2.6.0.

https://github.com/preactjs/compressed-size-action/tags

v2 (2.6.0) uses node20 runtime.

https://github.com/preactjs/compressed-size-action/blob/v2/action.yml#L46

@rhysd
Copy link
Owner

rhysd commented May 10, 2024

I'm not understanding what is your issue and why this change can fix it. Can you elaborate on it? v2 tag is dynamically updated.

@rhysd
Copy link
Owner

rhysd commented May 10, 2024

OK, I think I could understand the issue.

  • v2.5.0 uses node12
  • v2.6.0 uses node16
  • v2 was recently updated from v2.5.0 to v2.6.0 (probably within a few days? since popular_actions.go was updated 3 days ago)

So v2 is still marked as outdated in popular_actions.go

Copy link
Owner

@rhysd rhysd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not acceptable since popular_actions.go is generated from script and should not be modified directly as the header of the file says.

I'll update it on my side.

@rhysd rhysd closed this in 9ace049 May 10, 2024
@ne-sachirou ne-sachirou deleted the preactjs/compressed-size-action@v2-is-new branch May 20, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants