Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Allow file name to include version information #5
Even if the archive file name contains version information (e.g. cmdname_v0.0.1_linux_amd64.tar.gz), it also works now, but it is not documented and I want it to become a spec.
Many of my tools are such, and if we crossbuild using goxc or goxz with the -pv option, we actually get the archive files in which name included version information.
In other words, it is useful to include the version information in the filename when comparing version at locally, and many package system (cpan, gem, rpm etc.) file name conventions usually include version information as well.
To avoid misunderstanding, let me confirm your intention at first. The structure of release is such as:
Is my understanding correct?
I confirmed that current implementation is fine. Current implementation only checks the suffix (OS and arch) of the release file name. So both
I added a test repo to check the test case here https://github.com/rhysd-test/test-release-contain-version/releases/tag/v1.2.3.