New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped subscription check preventing writes to the database. #109

Closed
ribbons opened this Issue Aug 22, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@ribbons
Owner

ribbons commented Aug 22, 2013

Original report from Matt Robinson at 10:15:59 on 2010-05-16

Now that issue #107 has been implemented (meaning that each thread correctly gets a different SQLiteConnection), this has highlighted an issue with the CheckSubscriptionsAsync method. The problem is that while looping through the current subscriptions, the data reader is kept open, meaning that the database is locked for writes until all of the subscriptions have been checked.

This is fine for users with a small number of subscriptions, but for large subscription lists this can mean that the database cannot be written to for periods of several minutes at a time, causing crashes in a number of different places.


Imported from Bug 249 in the NerdoftheHerd.com Bugzilla.

@ribbons

This comment has been minimized.

Owner

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 15:52:52 on 2010-05-16

Resolved in e75bc36 by modifying the code to read the list of subscriptions into memory first and close the reader, before then checking all of the subscribed programmes for new episodes.

@ribbons ribbons closed this Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment