New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopped the StoreProgrammeInfo function from concealing provider exceptions. #112

Closed
ribbons opened this Issue Aug 22, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@ribbons
Owner

ribbons commented Aug 22, 2013

Original report from Matt Robinson at 17:12:13 on 2010-05-28

Currently, when a user selects a subscription in the episode list, UpdateProgInfoIfRequiredAsync ends up being called, which calls StoreProgrammeInfo but discards any information about exceptions being returned from it. As programme information is not updated automatically, it would be better to move the exception handling code from FindNewPluginInst_FoundNew into StoreProgrammeInfo itself so that the Exceptions are never discarded.


Imported from Bug 269 in the NerdoftheHerd.com Bugzilla.

@ghost ghost assigned ribbons Aug 22, 2013

@ribbons

This comment has been minimized.

Owner

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 11:32:30 on 2010-07-18

Resolved by removing the exception handling code from the StoreProgrammeInfo function in a5ec492. This does mean that exceptions in the provider will now crash the application, but this is better than them being caught and silently discarded some of the time.

@ribbons ribbons closed this Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment