New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown download errors are now serialised as binary instead of XML. #184

Closed
ribbons opened this Issue Aug 22, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@ribbons
Owner

ribbons commented Aug 22, 2013

Original report from Matt Robinson at 12:21:34 on 2012-09-10

Currently, the data for unknown download errors is stored as an xml serialisation of a list of DldErrorDataItem objects. However, the drawback to doing this is that .NET has to generate and compile a temporary XML serialisation assembly to do this, which is slow and also seems fairly prone to failure (broken compilers, disk space, permissions etc).

It would be more reliable, faster (and use less space) to serialise the data to binary format instead.


Imported from Bug 697 in the NerdoftheHerd.com Bugzilla.

@ghost ghost assigned ribbons Aug 22, 2013

@ribbons

This comment has been minimized.

Owner

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 12:45:41 on 2012-09-10

Implemented in 70e7f4c - the code now just serialises an ErrorReporting object to the database as binary instead of fiddling about with generic lists of DldErrorDataItem objects.

@ribbons ribbons closed this Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment