New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex HTML in podcast descriptions now converted into more readable text. #198

Closed
ribbons opened this Issue Jun 16, 2014 · 0 comments

Comments

Projects
None yet
1 participant
@ribbons
Owner

ribbons commented Jun 16, 2014

If a podcast doesn't have an <itunes:summary> tag for an episode, the <description> tag is used instead which contains HTML. This is converted to plain text for display in Radio Downloader using some simple regular expressions and HttpUtility.HtmlDecode which works fine for simple HTML but fails with complex markup e.g. containing nested conditional comments.

This can be seen for example in http://alanoleary.libsyn.com/rss (looks like the description tag is generated in MS Word).

@ribbons ribbons added the bug label Jun 16, 2014

@ribbons ribbons added this to the 0.30 milestone Jun 16, 2014

@ribbons ribbons changed the title from HTML entities in podcast episode descriptions are not decoded to Complex HTML in podcast descriptions not converted into readable text Jun 16, 2014

ribbons added a commit that referenced this issue Jun 18, 2014

Improve conversion of podcast description to text
Replace the basic method used to convert HTML podcast descriptions into
plain text with one that uses the HTML agility pack library (loosely based
on the HtmlToText sample code) which makes it much more robust when
dealing with complex HTML.

This resolves issue #198.

@ribbons ribbons closed this in dca9fc1 Jun 18, 2014

@ribbons ribbons added the fixed label Jun 18, 2014

@ribbons ribbons changed the title from Complex HTML in podcast descriptions not converted into readable text to Complex HTML in podcast descriptions now converted into more readable text. Jun 18, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment