New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a crash if the user's download and Documents folders do not exist when starting a download. #76

Closed
ribbons opened this Issue Aug 22, 2013 · 1 comment

Comments

Projects
None yet
1 participant
@ribbons
Owner

ribbons commented Aug 22, 2013

Original report from Matt Robinson at 17:50:10 on 2009-11-05

Currently, the application silently falls back to storing downloads in a sub folder of My Documents if the user's specified download folder does not exist. However, this is a problem if the My Documents folder does not exist either, which causes an exception to be thrown.

My suggested fix is:

  1. Move the code to fetch the download folder from FindAndDownload to DownloadProgThread in the data class, and make this raise a download error if a DirectoryNotFoundException is thrown and explain that the user's chosen download folder does not exist.
  2. Adjust the GetSaveFolder function in the FileUtils class to throw a DirectoryNotFoundException if the user has specified a download folder, and it doesn't currently exist. If the user has not specified a folder, and a DirectoryNotFoundException is thrown when fetching the location of My Documents it should return a folder in the root of the system drive instead as a fairly safe fallback.

Imported from Bug 159 in the NerdoftheHerd.com Bugzilla.

@ghost ghost assigned ribbons Aug 22, 2013

@ribbons

This comment has been minimized.

Owner

ribbons commented Aug 22, 2013

Original comment from Matt Robinson at 19:21:12 on 2009-12-08

Implemented the fix suggested above in 1c2afeb.

@ribbons ribbons closed this Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment