Join GitHub today
Added Programme Name to the available columns for the Downloads list. #212
Hey, thanks for your PR
Looks good generally - one thing that jumps out though is that the changes to
installer/Installer.wixproj as well as the addition of
Providers/PodcastProvider don't seem to be related to this change, could you drop them out of the PR? Let me know if you aren't sure how to do that.
I'll sprinkle a few other comments through the changes of things that occur to me.
Oh, also - could you add yourself to
AUTHORS.md and update the copyright date in the headers of the files you've changed.
Hi Matt, Many thanks for the reply. Haven’t much experience using GitHub, thus wasn’t too sure how to make contact with you re all of this. Seems though that this PR did the trick. Really appreciate the feedback and will work through all of the points you’ve listed. Re the ‘Providers’ and ‘Installer’ etc., I’m assuming its probably as simple as clicking the respective files (or folders) and asking GitHub to ignore them but any pointers you can give me there would be appreciated. Regards Neil
Yes, absolutely the right way
I'm not aware of an option like that, but I may have missed it. I'd suggest something along these lines from your local repository:
Then make the other changes you want to make, and round off with:
Not sure if you are new to Git as well as GitHub, but if so - although it seems totally baffling at first it is an incredibly powerful and useful tool.
To save you the trouble of having to make more changes, I took the liberty of pushing an additional commit which removed an unused variable and the addition to .gitignore (feel free to add that via another PR if you intended to add it), fixed some newline at end of file issues and tweaked the AUTHORS.md file wording.