Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo error message AccountDB to UserDB #42

Closed
wants to merge 3 commits into from
Closed

Fix typo error message AccountDB to UserDB #42

wants to merge 3 commits into from

Conversation

julienkosinski
Copy link
Contributor

Also result of go fmt :).

@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...e5623b8. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...e5623b8. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...7031628. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...21ffd24. Read the comment docs.

2 similar comments
@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...21ffd24. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...21ffd24. Read the comment docs.

@julienkosinski
Graceful shutdown with native go1.8 feature
71cd857 
Unfortunatly, facebookgo/grace isn't compatible with Windows OS although
go 1.8 graceful HTTP shutdown feature is.
@julienkosinski
Fist swagger.json int type, clean files
de265d1 
cmd/api/swagger.json seemed to be unused so it has been deleted. cmd/api/swaggerui/swagger.yml added and used by default to switch to OpenAPI 3 and YAML thanks to https://openapi-converter.herokuapp.com/
@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...de265d1. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #42 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         502      502           
=======================================
  Hits          484      484           
  Misses         11       11           
  Partials        7        7
Impacted Files Coverage Δ
internal/platform/postgres/user.go 91.66% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ef0ff...de265d1. Read the comment docs.

@ribice
Copy link
Owner

ribice commented Sep 19, 2018

Please make multiple PRs for your changes (accountDB -> userDB, graceful shutdown, swagger changes, typos etc.).

Thanks!

@ribice ribice closed this Sep 19, 2018
@julienkosinski
Copy link
Contributor Author

julienkosinski commented Sep 19, 2018 •
edited

@ribice Sorry, indeed that's an error, wasn't on purpose to add these to the pull request. Wasn't aware of this behavior of Github.
Multiple PR needs multiple branches, understood :).

@ribice
Copy link
Owner

ribice commented Sep 20, 2018

Yes, please make them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julienkosinski @codecov-io @ribice