Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"deflate": is this zlib format or raw format? #8

Open
ricea opened this issue Sep 16, 2019 · 2 comments

Comments

@ricea
Copy link
Owner

commented Sep 16, 2019

It's ambiguous whether the "deflate" format is raw or includes the zlib header and footer. It might be good to rename it--maybe "deflate-raw".

@ericlaw1979

This comment has been minimized.

Copy link

commented Sep 16, 2019

Yeah, I think it makes the most sense to match HTTP Content-Encoding and have 'deflate' mean Zlib-wrapped DEFLATE (RFC1950)

Node uses 'deflateRaw' for the bare format and this sounds reasonable.

@ricea

This comment has been minimized.

Copy link
Owner Author

commented Oct 2, 2019

@ericlaw1979 Thanks. We settled on using "deflate" to mean "zlib" for consistency with HTTP, and will add "deflate-raw" in future to support zip and other use cases where the header and footer are unwanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.