Skip to content

Jason Rice
ricejasonf

ricejasonf commented on issue boostorg/hana#175
@ricejasonf

@ldionne That's fine, but the idea is that they could all have an optional callback argument. Other than that perhaps functions like find_key, find…

@ricejasonf
@ricejasonf
@ricejasonf
@ricejasonf
  • @ricejasonf 5c23006
    EntityMeta and EntityKeyMeta
ricejasonf commented on pull request boostorg/hana#250
@ricejasonf

No sweat! :sweat_smile:

ricejasonf commented on pull request boostorg/hana#250
@ricejasonf

btw #213

ricejasonf commented on pull request boostorg/hana#250
@ricejasonf

I reset back to earlier and simply added friend to all free operators. I also added type's unary+ and everything for integral_constant.

@ricejasonf
  • @ricejasonf c2a4d58
    [documentation] operator documentation
ricejasonf commented on pull request boostorg/hana#250
@ricejasonf

I perhaps went too far with breaking out the free operators, but I pushed it for review to see if this is a better solution. If not, I can reset ba…

@ricejasonf
ricejasonf commented on pull request boostorg/hana#250
@ricejasonf

I just broke all of these free functions out into a separate file and then realized that maybe you meant that I simply add the friend keyword there…

ricejasonf commented on pull request boostorg/hana#250
@ricejasonf

I just broke all of these free functions out into a separate file and then realized that maybe you meant that I simply add the friend keyword there…

@ricejasonf
  • @ricejasonf 3060e23
    build ProviderMap from meta
ricejasonf commented on issue boostorg/hana#175
@ricejasonf

The members function could take an optional, second callback argument that behaves like unpack. I also threw in a member_refs convenience function …

ricejasonf commented on pull request boostorg/hana#247
@ricejasonf

Now that you are injecting the HashTable, perhaps it could be more general and call it something like LookupTable. We could then have a special mak…

ricejasonf opened pull request boostorg/hana#250
@ricejasonf
Documentation/operators
2 commits with 172 additions and 3 deletions
@ricejasonf
  • @ricejasonf e1af1a7
    [documentation] remove integral_constant deref
@ricejasonf
  • @ldionne c3a195b
    [benchmarks] Reduce the size of map benchmarks to reduce CI timeouts
  • @ldionne 12939a0
    [build] Satisfy the Boost library requirements for testing
  • 12 more commits »
@ricejasonf
ricejasonf commented on issue boostorg/hana#90
@ricejasonf

Sorry if this is a little late in the conversation. In the OP example with the struct, I think it would be beneficial to change the usage to be mor…

@ricejasonf
@ricejasonf
  • @ricejasonf 4cfe1ee
    [WIP] enumerate providers and build provider
@ricejasonf
  • @ricejasonf 4635cf2
    ProviderMap maps paths to providers
@ricejasonf

The comment has since been removed.

@ricejasonf

That reminds me. We should either specialize contains or make contains call find instead of find_if.

@ricejasonf

No, I meant to revert all of the functions back other than the ones that benefited from the hash lookup (ie at_key, find, erase_key). I guess I jus…

@ricejasonf
ricejasonf commented on pull request boostorg/hana#242
@ricejasonf

I just pushed 295f5fc to fix hash for type_tag.

Something went wrong with that request. Please try again.