Window-decorations aren't shown (Xfmw4) #13

Closed
ochosi opened this Issue Jun 21, 2013 · 11 comments

Comments

Projects
None yet
3 participants

ochosi commented Jun 21, 2013

Somehow when I run skippyxd it only shows the window content, but without the window-decoration. That looks a bit odd to me, maybe it can be fixed. Thanks!

Owner

richardgv commented Jun 21, 2013

This is actually intentional. skippy-xd reads the image from the client window instead of the outer WM frame window. We may add an option to display frame in the future, though.

ochosi commented Jun 22, 2013

I see. I guess it just didn't look intentional.
If getting the window-decoration for real is too resource-intense, maybe drawing a simple cairo box around it would help?

Owner

richardgv commented Jun 22, 2013

I see. I guess it just didn't look intentional.
If getting the window-decoration for real is too resource-intense, maybe drawing a simple cairo box around it would help?

We don't use cairo, and drawing a box ourselves is much more troublesome than using the frame window directly. :-) But thanks for the suggestion.

ochosi commented Jun 22, 2013

OK – haven't had time to look into the source yet ;)

Owner

richardgv commented Jun 22, 2013

Sorry for the delay. This is a quick-'n'-dirty implementation < https://gist.github.com/richardgv/5696281 >. Apply the patch and you could use includeFrame = true to include frame in mini windows, as shown in skippy-xd.rc-defaults. Give me some extra time to integrate all the things to the repo.

ochosi commented Jun 22, 2013

You call 4 hours from a comment to implementation a feature a "delay"? :D
Take your time to integrate it to the repo, I gotta finish some work as well before I can build from git (so far I've lazily been using the PPA).

This patch works really great! Skippy looks much better now, and I haven't noticed any slowdowns. It just says "Segmentation Fault" at the end, but it activates the correct window anyway and the daemon doesn't segfault either, so everything seems to be OK so far.

richardgv added a commit that referenced this issue Aug 20, 2013

Feature: Background image
- Note: Only mininum tests are done, since I don't have enough time
  right now. Expect bugs.

- Introduces background image support, with PNG/JPEG/GIF reading
  capability. (libpng/libjpeg/giflib) Syntax is explained in
  skippy-xd.rc-default .

- Introduces a certain degree of support for non-EWMH/GNOME compliant
  WMs. (#14, #20)

- Include window decoration in thumbnails if requested. (#13)

- (Hopefully) fixes high CPU usage. (#17)
Owner

richardgv commented Aug 20, 2013

@teresaejunior:

Thanks! I've merged the patch into master (f6e1690), without enough tests, as I don't have the time right now. If the segfaults is still there, could you please obtain a backtrace with gdb? (Please show us bt full, not bt.)

Owner

richardgv commented Aug 21, 2013

@teresaejunior:

Huh, sorry for the delay, and thanks for the report. I couldn't reproduce the issue, but probably that's a bug in the patch revision I made last night. Are you sure you are using the latest version from the git repo (f6e1690), which already includes the patch?

I had applied the patch mentioned on this thread. Now I have compiled the clean source from git and the error is gone. Thank you!

@richardgv richardgv closed this Nov 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment