Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misidentifications when running with -multi flag #117

Closed
richardlehane opened this Issue Jun 15, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@richardlehane
Copy link
Owner

richardlehane commented Jun 15, 2018

Testing on Greg Lepore's PRONOM FILES corpus have found that the -multi flag can cause misidentifications for a small number of OLE container files. These misidentifications don't reliably occur so looks to be some kind of race condition

@richardlehane richardlehane added the bug label Jun 15, 2018

@richardlehane richardlehane self-assigned this Jun 15, 2018

@richardlehane

This comment has been minimized.

Copy link
Owner Author

richardlehane commented Jun 16, 2018

Traced this down to the github.com/richardlehane/mscfb library. A global sectorSize variable made that package unsafe for concurrent usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.