Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sf panics scanning fmt/1172 file of skeleton suite with freedesktop.org identifier #125

Closed
richardlehane opened this issue Mar 31, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@richardlehane
Copy link
Owner

commented Mar 31, 2019

discovered by @ross-spencer
to reproduce: 1) use deluxe.sig or freedesktop.sig; 2) scan fmt-1172 file within skeleton suite
Panics at line 456 of mimeinfo/identifier.go applyscore method.

@richardlehane richardlehane changed the title sf panics scanning fmt/1172 file of skeleton suite with mimeinfo identifier sf panics scanning fmt/1172 file of skeleton suite with freedesktop.org identifier Mar 31, 2019

@richardlehane

This comment has been minimized.

Copy link
Owner Author

commented Mar 31, 2019

maybe due to the fact that freedesktop.org has a double-entry for font/woff

@richardlehane richardlehane self-assigned this Mar 31, 2019

@richardlehane richardlehane added the bug label Mar 31, 2019

@richardlehane

This comment has been minimized.

Copy link
Owner Author

commented Apr 1, 2019

I've tested a fix on the develop branch that reports an error where a mimeinfo signature file duplicates IDs. In doing so, discovered both the freedesktop.org.xml and tika-mimetypes.xml files have duplicate IDs.
In both cases, these appear to be errors in those files:

  • in the freedesktop case, the second entry for font/woff should be font/woff2
  • in tika's case, the whole entry for application/x-gtar is duplicated for some reason.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.