Skip to content

Roy expects quotation marks in Droid csv from Siegfried for comparison #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ostnatalie opened this issue Jan 5, 2022 · 1 comment
Closed
Assignees
Labels

Comments

@ostnatalie
Copy link

Hello,
We tried to use Roy for comparing output files from Siegfried and Droid. We were comparing Droid csv output from Siegfried and csv output from using this command:

roy compare file1.csv file2.csv > comparison.csv

We got this:

“2022/01/05 09:57:39 not a valid results file, bad char 73”

(file1 is Droid csv from Siegfried, file2 is from Droid)

We have found out that it was probably caused by the “missing” quotation marks in column names in Droid csv from Siegfried.

Output from Droid
Droid_output

Output from Siegfried
image

When we added the quotation marks to that Siegfried output then Roy carried out the comparison.

So we are sending this in case it could be useful information, that Roy expects the quotation marks in the Droid csv output from Siegfried.

We then tried it with JSON output from Siegfried and with normal csv from Siegfried and it worked perfectly.

@richardlehane
Copy link
Owner

thanks for reporting this @ostnatalie - I expect this will be a general bug in how siegfried reads droid-formatted csv files it has created itself (so will impact sf -replay functionality too). I'll try to fix for the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants