Add JS/WASM platform mmap no-op implementation. #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, so hacking our the dependency on But, other than that, with these changes, I managed to successfully run a Siegfried identification process in the browser via WebAssembly. See https://github.com/ukwa/siegfried-js#readme |
|
look forward to trying this out, thanks Andy! |
|
Thanks Richard. I just realised I could extend the existing conditional build settings for |
richardlehane
pushed a commit
that referenced
this pull request
Mar 20, 2023
* test fails if close reader before drained * Add JS/WASM platform mmap dummy implementation. * Make lack of user.Current a non-fatal error. * Shift signature file reader into LoadReader so it can be used on non-file sources. * Cleaner to simply omit this file from js builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add an no-op implementation of
mmapfor thejsplatform. With this in place, Siegfried compiles under:NOTE THAT THIS HAS NOT YET BEEN TESTED!Now tested and seems to work well, see https://github.com/ukwa/siegfried-js#readme