Implement digippres.org changes and min sig length#253
Merged
richardlehane merged 3 commits intoJul 15, 2024
Conversation
A filter is introduced to return more relevant results, rather than nearly everything on Wikidata. The query also introduces file format family signatures which can be handled equally by Siegfried and fills some gaps in identification. Co-authored-by: Andrew Jackson <andrew.jackson@dpconline.org>
This reduces the query time further and tackles some of the issues in: ffdev-info/wikidp-issues#32 The signature length can be configured but the default while we calibrate is '6', i.e. 3 bytes.
Collaborator
Author
|
@richardlehane cc. @thorsted -- is there any chance we can build a release candidate with these changes to trial them? |
Owner
|
@ross-spencer @thorsted these changes now on the develop branch and built as a release candidate (Version 1.11.2-rc0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filter has been added to the default query to reduce the number of results relevant to us. This reduces the Wikidata query service query time as well as the amount of time required to generate provenance.
Additionally, because of TrID issues, we implement a minimum signature length that reduces time even further.
Connected to: ffdev-info/wikidp-issues#32
Connected to: #183
Connected to: ffdev-info/wikidp-issues#38
Co-authored-by: @anjackson
With filter
With siglen min 6 (3 bytes) signature length: