Support explicitly declared variable length offsets#267
Merged
Conversation
A `<ByteSequence>` without a `Reference=...` was previously assumed to indicate variable length offset; however, variable length offsets may also be declared explicitly using `Reference="Variable"`. The only file format that currently uses this explicit form is WACZ (fmt/1840).
Owner
|
Thanks for this PR Rijnder, I check and merge shortly ... [edit] & WACZ support would be very welcome! Siegfried's warc/arc decoding is all in this repo: https://github.com/richardlehane/webarchive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
<ByteSequence>without aReference=...attribute was previously assumed to implicitly indicate a variable length offset; however, variable length offsets may also be declared explicitly usingReference="Variable". The only file format that currently uses this explicit form is WACZ (fmt/1840):With this commit,
siegfriedcan now thus differentiate WACZ from ZIP files — provided, at least, that you are also using a container signature file released in 2024 or later.I can take a look at adding support for WACZ files in siegried later as well, since both WACZ and siegfried are important for some projects I'm working on!