New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill defaults not correctly accounting for talents #12

Closed
Xavion3 opened this Issue Apr 19, 2017 · 2 comments

Comments

3 participants
@Xavion3

Xavion3 commented Apr 19, 2017

Skills appear to default off whatever would work best, if you incorporate any bonuses from talents to the skill it's defaulting off. It correctly calculates skill level ignoring talents, but it does not correctly work out which skill to default off.

@Xavion3 Xavion3 changed the title from Skills not defaulting off best option to Skill defaults not correctly accounting for talents Apr 19, 2017

@angelforest

This comment has been minimized.

Show comment
Hide comment
@angelforest

angelforest Apr 19, 2017

Contributor

test defaults and talent.zip.gz (github acting weird with zip resolution)
Here is file demonstrating issue. Try to switch advantage on and off and see how it affects skills.

I made quick fix but I am not sure if it will have any unintended side-effects: angelforest@4d8a12b

Contributor

angelforest commented Apr 19, 2017

test defaults and talent.zip.gz (github acting weird with zip resolution)
Here is file demonstrating issue. Try to switch advantage on and off and see how it affects skills.

I made quick fix but I am not sure if it will have any unintended side-effects: angelforest@4d8a12b

richardwilkes added a commit that referenced this issue Oct 28, 2017

@richardwilkes

This comment has been minimized.

Show comment
Hide comment
@richardwilkes

richardwilkes Oct 28, 2017

Owner

I think @angelforest 's change is appropriate and I've incorporated it in commit cf9b143

Owner

richardwilkes commented Oct 28, 2017

I think @angelforest 's change is appropriate and I've incorporated it in commit cf9b143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment