Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technique displayed RSL Bugs out when Technique level improved via advantage #94

Closed
Legendsmith opened this issue Nov 10, 2018 · 3 comments

Comments

@Legendsmith
Copy link

commented Nov 10, 2018

Replication:
Add Karate, and Karate feint
Create an advantage that gives +1 per level to Feint (Karate).
Increase the advantage level to 4
The RSL still shows, even though it should be +4
Increasing it past the restricted level will make the RSL start counting BACKWARDS! (See attached image)

I'm modifying technique levels via advantage in order to use different technique pricing, but while the SL shows just fine, the RSL does not, and that's confusing.
image

@richardwilkes

This comment has been minimized.

Copy link
Owner

commented Nov 12, 2018

Well, that's clearly not appropriate... I'm unfortunately very busy with work (and soon holiday-related things), so not sure when I'll get a spare moment to take a look. Hopefully I can fit it into the cracks somewhere...

@richardwilkes

This comment has been minimized.

Copy link
Owner

commented Nov 12, 2018

Oh, and it would help if you attached a file that illustrates the problem -- your description looks clear enough that I shouldn't have any trouble replicating it, but having a known failing case already available is handy.

@Legendsmith

This comment has been minimized.

Copy link
Author

commented Nov 13, 2018

Oops, I just realised I submitted this to GCS library, not GCS, my bad, I think I had both open at once.
Here's a file anyway.
Technique_bug.zip

@richardwilkes richardwilkes transferred this issue from richardwilkes/gcs_library Feb 18, 2019

@richardwilkes richardwilkes added the bug label Feb 18, 2019

richardwilkes added a commit that referenced this issue Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.