Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tooltips for Spells & Weapon Damage #113

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@crnormand
Copy link
Contributor

commented Jul 12, 2019

This adds tooltips for Weapon Damage and Spells. It is a slightly bigger PR than before, but it follows the same pattern as Skill.

  1. I had to increase the tooltip time so that the user has time to actually read the bonuses. I wasn't certain where you would want that kind of change, so I put it in GCS.java.

  2. The other GURPSCharacter "getBonus" methods had to be updated to include the tooltip.

  3. In the previous PR, I did not completely update the PrerequisitesThread class. I missed a few places where the parent needed to be set.

  4. Similar to the Skill PR, Spell's now use an instance of SkillLevel to maintain their level and relative level. Also, the Spell calculation methods needed to be updated with tooltips.

  5. SpellColumn now shows tooltips for the Level and Relative Level columns.

  6. WeaponColumn now shows tooltips for the Damage column.

  7. WeaponDisplayRow and WeaponStats have been updated to calculate a tooltip while determining damage.

@@ -233,6 +235,9 @@ private static void initialize() {
Fonts.loadFromPreferences();
App.setAboutPanel(AboutPanel.class);
registerFileTypes(new GCSFileProxyCreator());

// Increase TooTip time so the user has time to read the skill modifiers
ToolTipManager.sharedInstance().setDismissDelay(60000);

This comment has been minimized.

Copy link
@richardwilkes

richardwilkes Jul 12, 2019

Owner

This is fine for the moment, but it really should be a preference the user can change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.