Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Category filtering to Spell Bonuses #118

Merged
merged 2 commits into from Jul 21, 2019

Conversation

@crnormand
Copy link
Contributor

commented Jul 21, 2019

This builds off of (and partially copies) the Skill categories code. The biggest issue here was the multiple ways you could add a spell bonus (by college, by name, by Power, etc.).

I built a large testcase that created bonuses for all of the combinations of college/power/name and category, to verify that the code works (and doesn't interfere with previous bonuses). So on this, you will have to trust me ;-)

image

The final PR will contain the code to support weapon bonuses by category.

@@ -2757,17 +2757,17 @@ public int getSkillComparedIntegerBonusFor(String id, String nameQualifier, Stri

/**
* @param id The feature ID to search for.
* @param qualifier The qualifier.
* @param qualifier The qualifier. #param categories The categories qualifier

This comment has been minimized.

Copy link
@richardwilkes

richardwilkes Jul 21, 2019

Owner

The parameter should be on its own line and start with @, not #

mNameCriteria = new StringCriteria(StringCompareType.IS, ""); //$NON-NLS-1$
mAllColleges = true;
mMatchType = TAG_COLLEGE_NAME;
mNameCriteria = new StringCriteria(StringCompareType.IS, ""); //$NON-NLS-1$

This comment has been minimized.

Copy link
@richardwilkes

richardwilkes Jul 21, 2019

Owner

Probably should use EMPTY here, too

@richardwilkes richardwilkes merged commit 7bf80a3 into richardwilkes:master Jul 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.