Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Thr=SW-2 damage option #124

Merged
merged 1 commit into from Jul 28, 2019

Conversation

@crnormand
Copy link
Contributor

commented Jul 26, 2019

I believe this solves #97. Since they were requesting "no modification to Basic Lifting and trait costs", it seemed simple enough.

It adds a preference option "Use optional Thrust damage (Thrust = Swing - 2)", and then just redirects the getThrust() method to the getSwing() method, minus 2.

I tested the notifications (although, I must admit, I was blindly copying code), but it seems to work correctly. If you change the option, you will see the Thr damage change, and you will see all of the weapon damages change (based on thrust).

@richardwilkes

This comment has been minimized.

Copy link
Owner

commented Jul 26, 2019

In general, this looks reasonable. How does it interact with the other options that modify damage, though? Seems like KYOS and this might be mutually exclusive (although I haven't looked close enough to know for sure). If so, then you shouldn't be able to enable them at the same time.

@crnormand

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

As I have implemented it, if you turn this feature on, it will redirect the getThrust() query to getSwing() before processing any other thrust damage options. I have not modified the getSwing() method, so if other strength or swing damage related options are turned on, they will affect the swing damage (and therefore the thrust damage).

It should be completely compatible with any combination of options, assuming the user understands that Thrust is just Swing -2, so there are no separate calculations (or modifiers) for thrust damage. You could say it is an "override" for Thrust damage.

@richardwilkes richardwilkes merged commit 3b18819 into richardwilkes:master Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.