Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A short list of incorrect entries #95

Closed
Sorenant opened this issue Feb 4, 2020 · 4 comments
Closed

A short list of incorrect entries #95

Sorenant opened this issue Feb 4, 2020 · 4 comments

Comments

@Sorenant
Copy link

@Sorenant Sorenant commented Feb 4, 2020

First of all, I can't thank you enough for maintaining this project, it's a real life saver for me.
I just updated from 4.11.1 to 4.14 and while updating some libraries to match my edited ones, I noticed some incorrect data has been carried on:
Basic Set:
-Damage Resistance gives +1 DR/level to "full body", when it should be "full body except eyes";
-Nictitating Membrane gives no DR, when it should give +1 DR/level to "eyes";
-Enhanced Defenses (Block, Dodge and Parry) is marked as non-leveled, when it should be leveled;
-Fearlessness gives no bonus to "Fright Check", when it should give +1/level.
Power Ups:
-Talent (Artificer) gives +1 to Masonry, Mechanic and Smith skills, when it should give +1/level;
-Talent (Stalker) gives bonus to "Navigation (Land)" skill with any specialization, when it should be "Navigation" skill with "Land" specialization;
-Huge Weapons (ST) costs 2 points/level, when it should cost 1 point/level;
-Shoves and Tackles has the description of Shield-Wall Training.

Not really an error, but here's a few edits I've done and would like to leave as suggestion:
-Instead of "Rank" advantage with "@type@:@title" description, I like to change it to "@type@ Rank" advantage with "@title@" description;
-Instead of "Ham-Fisted" and "Ham-Fisted (Severe)" advantages, I like to fold them into a leveled one by removing the Severe variant and editing the other to be leveled;
-Instead of "Legal Enforcement Powers" with 3 mutually exclusive modifiers (Cop, FBI, KGB), I like to turn the advantage into a leveled one, remove the modifiers and add "@description@" to the description;
-Instead of multiple "Injury Tolerance" entries, I like to create a 0 point one with each variant as a modifier.

I think that's all I have, cheers and thank you again for your work.

@richardwilkes

This comment has been minimized.

Copy link
Owner

@richardwilkes richardwilkes commented Feb 4, 2020

The best way to get these incorporated is to load the latest version of the relevant files, unlock them, make the edits and save, then either attach them to this request or better yet, if you know how to use git and GitHub, make a Pull Request for them.

If not, I'll eventually get around to them, but I rely on the community to provide the data for the most part.

@Sorenant

This comment has been minimized.

Copy link
Author

@Sorenant Sorenant commented Feb 4, 2020

Unfortunately I don't know how to use Pull Requests, so here's a zip with the fixed trait list. It includes my personal changes I listed in the second part of the post, if it bothers you just tell me and I'll make an archive without it.

Fixed ADQs.zip

@richardwilkes

This comment has been minimized.

Copy link
Owner

@richardwilkes richardwilkes commented Feb 4, 2020

Thanks, @Sorenant -- I'll incorporate these changes into the repo once I find a few spare moments.

richardwilkes added a commit that referenced this issue Feb 27, 2020
@richardwilkes

This comment has been minimized.

Copy link
Owner

@richardwilkes richardwilkes commented Feb 27, 2020

Will be included as part of the next release, whenever that is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.