Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Low Tech shields. #71

Merged
merged 3 commits into from Feb 18, 2019

Conversation

@ubik2
Copy link
Contributor

commented Feb 5, 2019

I moved the unusual block modifiers into the melee_weapon section instead of the attribute_bonus section, which should have been my initial approach. This eliminates the issue where the outline wasn't updated. It's possible the CharacterSheet.handleNotification should still be altered to support hypothetical equipment that provides an attribute_bonus to block and not parry, but all of these shields either provide both or neither.

CharacterSheet.handleNotification refreshes the outline on an update of ID_PARRY_BONUS, but not ID_BLOCK_BONUS.

@richardwilkes

This comment has been minimized.

Copy link
Owner

commented Feb 18, 2019

It is normal for a slight delay to occur while the sheet stats are being recomputed. How long that delay is depends a lot on how complex the sheet is in terms of interactions and how fast your computer is. In my (very limited) experiments, I couldn't get the failure you mentioned regarding updating -- if you have an example that illustrates this, I'd be happy to take a look.

@richardwilkes richardwilkes merged commit 7fdd0f7 into richardwilkes:master Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.