Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Multiple OS X patches #9
changed the title from
Patch elf.h circular dependency out of linux-4.4.10
Multiple OS X patches
May 20, 2016
referenced this pull request
May 30, 2016
Do you have good reason to believe the linux patch doesn't break anything? The archscripts target and dependency for __headers was added in commit 6520fe5564 seemingly for a reason. If archscripts are never needed for producing headers that should probably be fixed, but if they're needed for some archs then it's perhaps more complicated. Can you look into this?
The binutils patch looks fine as-is; it matches the upstream fix.
As I believe I noted somewhere else, adding CXX=[anything] to *_CONFIG by default is problematic because it will conflict with settings in the user's config.mak. I think we should consider one of the following 3 approaches:
While 3 seems nice in some ways, it's also something of a big hammer/almost-gratuitous complexity, so I'd lean towards one of the other options.
At least in 4.4.10, the only archscripts target is x86, which I can build just fine. Also the only tool is relocs, which I really really can't tell how it can be used in install-headers. I suspect adding the archscripts dependency has been either a shortcut or a mistake.
Yeah, I had misinterpreted. Agreed on 3 being overkill. I'd prefer 2 but I'm running out of time budget for this :) so I'm striking that patch out. I'll leave the issue open for you to decide what to do, and add the line to config.mak in the Homebrew Formula.