Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip scratch #116

Open
wlandau opened this issue Nov 28, 2019 · 1 comment
Open

Option to skip scratch #116

wlandau opened this issue Nov 28, 2019 · 1 comment

Comments

@wlandau
Copy link
Contributor

@wlandau wlandau commented Nov 28, 2019

When I run this drake benchmark on Windows, file.rename() is a bottleneck (second flame graph here). Would you be open to a global cache option to bypass scratch/ and write directly to the final destination? I know scratch/ prevents race conditions in the general case, but for RDS storrs, drake never tries to write to the same file from two concurrent processes.

Related: #114.

@wlandau
Copy link
Contributor Author

@wlandau wlandau commented Dec 3, 2019

Hmm... there is a chance this will conflict with #80 in some cases. But drake has changed a lot since then, including a couple changes that should avoid the need for atomic writes. I will investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant