Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

JS compatibility updates and minor install.md updates #25

Closed
wants to merge 5 commits into from

2 participants

only_samurai Richo Healey
only_samurai

This seems to want to include the install guide itself (perhaps the #22 PR wasn't accepted yet?), nonetheless there is also a small modification to that included in this.

This is mostly JS updates to the way grefs are drawn and updates are pushed so that it works for firefox. I've done basic testing on these changes and believe them to be cross-compatible with most things, tho IE seems to not like it

Richo Healey
Owner

The comment would be better off in the commit message. Commit messages are forever, source comments are transient.

It is :)

I've done some testing (basic), but I believe this fix should be cross-compatible with most browsers (whatever version of IE I currently have running tho doesn't like it tho ...)

Richo Healey
Owner
richo commented

Yup, you generally want to start new features off master git checkout -b features/foo_thing master

I'll have a look over this and probably rebase it into master.

Richo Healey

Did you work out what to do about whitespace with this? When I try this it maims my markdown.

Richo Healey
Owner
richo commented

I rebased 1380c00 in e17076b so that can come out of this PR.

The rest I'll need to check over, but I'm pretty sure text()

Richo Healey richo commented on the diff
airship/static/airship.js
@@ -112,7 +112,7 @@ var GrefMenuItem = Backbone.View.extend({
112 112
113 113 select: function() {
114 114 var active_el = this.el;
115   - $(this.el.parentElement.children).removeClass("active");
  115 + $(this.el.children).removeClass("active");
4
Richo Healey Owner
richo added a note

I just tested in FF and chrome, this Just Works for me.

What are you seeing?

only_samurai
samurai added a note

I get no content, it errors out on that element not existing. When enumerating the items in this.el, parentElement doesn't show up in the FF builds I tested under. this.el.children seemed to be supported across all browsers I tested, and presumably contains identical datas

Richo Healey Owner
richo added a note

something weird is happening :/

Maybe

$(this.el.children || this.el.parentElement.children)

until we can work out why it's doing that? What ff version are you testing on? this.el.children was broken everywhere I tried it.

only_samurai
samurai added a note

As it turns out, that one I only tested under a really old version of FF =\ disregard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
only_samurai

@richo , forgot about the whitespace issue with that. If you haven't already looked into it, I'll knock that out

Richo Healey
Owner
richo commented

@samurai I ported all the markdown'y bits to just use textareas: https://github.com/richo/groundstation/pull/23/files

Richo Healey
Owner
richo commented

Closing, I'm pretty sure this is all on master now.

Richo Healey richo closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.

Showing 2 changed files with 44 additions and 2 deletions. Show diff stats Hide diff stats

  1. +42 0 INSTALL.md
  2. +2 2 airship/static/airship.js
42 INSTALL.md
Source Rendered
... ... @@ -0,0 +1,42 @@
  1 +INSTALLATION GUIDE
  2 +
  3 +This guide comes with no warrenty or assurance of correctness. It's mostly meant as a guideline.
  4 +Your milage may vary. Many commands assume you have (or can get) root priveldges. Good luck!
  5 +
  6 +
  7 +__install gcc__
  8 +Distro-dependent
  9 +
  10 +__install cmake__
  11 +Distro-dependent
  12 +
  13 +__install python's protobuf (google)__
  14 +python -m easy_install protobuff
  15 +
  16 +__install flask__
  17 +python -m easy_install flask
  18 +
  19 +__install pycrypto__
  20 +python -m easy_install pycrypto
  21 +
  22 +These next two need to be from the repos for now, as the patches havent been pushed out yet
  23 +
  24 +__install libgit2__
  25 + git clone git://github.com/libgit2/libgit2.git
  26 + follow cmake instructions
  27 +(you must remove old version of libgit2 and it's devel headers)
  28 +
  29 +__install pygit2__
  30 +git clone https://github.com/libgit2/pygit2.git ./pygit2
  31 +sudo python setup.py install
  32 +
  33 +__install github (python)__ - going to be depricated
  34 +python -m easy_install pygithub
  35 +
  36 +__Groundstation setup__
  37 +Odds are good if you're reading this, you've already done the following, but incase you're viewing this via a browser:
  38 +git clone https://github.com/richo/groundstation ./groundstation
  39 +
  40 +cd groundstation
  41 +
  42 +python stationd
4 airship/static/airship.js
@@ -112,7 +112,7 @@ var GrefMenuItem = Backbone.View.extend({
112 112
113 113 select: function() {
114 114 var active_el = this.el;
115   - $(this.el.parentElement.children).removeClass("active");
  115 + $(this.el.children).removeClass("active");
116 116 rendered_gref.url = this.getUrl();
117 117 rendered_gref.fetch({
118 118 success: function(model, response, options) {
@@ -206,7 +206,7 @@ function buildCommentBox(div, model) {
206 206 type: "POST",
207 207 url: model.url,
208 208 data: {
209   - body: input.innerText,
  209 + body: $(input).text(),
210 210 parents: JSON.stringify(model.attributes["tips"]),
211 211 user: groundstation.username
212 212

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.