Browse files

drivers/tty/vt/vt_ioctl.c: fix KDFONTOP 32bit compatibility layer

KDFONTOP(GET) currently fails with EIO when being run in a 32bit userland
with a 64bit kernel if the font width is not 8.

This is because of the setting of the KD_FONT_FLAG_OLD flag, which makes
con_font_get return EIO in such case.

This flag should *not* be set for KDFONTOP, since it's actually the whole
point of this flag (see comment in con_font_set for instance).

Signed-off-by: Samuel Thibault <>
Reviewed-by: Arnd Bergmann <>
Cc: Greg Kroah-Hartman <>
Cc: Arthur Taylor <>
Cc: Jiri Slaby <>
Cc: Jiri Olsa <>
Cc: <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
  • Loading branch information...
1 parent 9261818 commit cbcb8346054073d000ecac324763372d6abd44ac @sthibaul sthibaul committed with torvalds Feb 3, 2012
Showing with 0 additions and 1 deletion.
  1. +0 −1 drivers/tty/vt/vt_ioctl.c
@@ -1463,7 +1463,6 @@ compat_kdfontop_ioctl(struct compat_console_font_op __user *fontop,
if (!perm && op->op != KD_FONT_OP_GET)
return -EPERM;
op->data = compat_ptr(((struct compat_console_font_op *)op)->data);
- op->flags |= KD_FONT_FLAG_OLD;
i = con_font_op(vc, op);
if (i)
return i;

0 comments on commit cbcb834

Please sign in to comment.