New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin selection to install #10

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@meshakeeb
Copy link

meshakeeb commented Aug 21, 2017

Fixes #9

@meshakeeb

This comment has been minimized.

Copy link

meshakeeb commented Aug 24, 2017

Hello @richtabor

Waiting for your feedback on the PR.

Thanks

@richtabor

This comment has been minimized.

Copy link
Owner

richtabor commented Aug 28, 2017

I like where it's headed. What do you think about having them selected by default (checkmarked) instead?

Currently, if the plugins are not selected and the user does not open the drawer to select them, the wizard shows the green checkmark when "Install" is clicked. That signifies the plugins have been successfully installed — although they have not been.

Make sense?

@meshakeeb

This comment has been minimized.

Copy link

meshakeeb commented Aug 29, 2017

Hi,

Working on it and also changing the style to the content importer list you have already done. And working on adding classes and text according to the steps.

image

Thanks

@richtabor

This comment has been minimized.

Copy link
Owner

richtabor commented Aug 29, 2017

Ok cool. What about if we used the same current green/yellow/red checkmarks as in the content importer?

@meshakeeb

This comment has been minimized.

Copy link

meshakeeb commented Aug 29, 2017

Hi,

I tried that but your processing functionality is adding classes on the right time i.e like adding classes in the second trip not the first one.

$current_node = $(this);
$current_node.find("span").removeClass('installing error success').addClass('installing');
$current_node.find("i").removeClass('installing error success').addClass('installing');

and

$current_node.find("span").text("failed").removeClass('installing error success').addClass('error');
$current_node.find("i").removeClass('installing error success').addClass('error');

This functionality need to be refactored with better code and response from server.

Thanks

@meshakeeb

This comment has been minimized.

Copy link

meshakeeb commented Aug 30, 2017

I am pushing changes for the plugin selection please have a look its working this way and also we need to test for plugins which redirect to welcome page i.e. bbpress, woocommerce.

image

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment