Refactor Config class #25

Closed
rickard2 opened this Issue Apr 6, 2013 · 3 comments

Comments

Projects
None yet
1 participant
Owner

rickard2 commented Apr 6, 2013

Split the Config class into separate classes to reduce complexity and mess.

Maybe the configuration options could be logically grouped into data/style/other or something similar.

https://scrutinizer-ci.com/g/rickard2/utcw/inspections/e1998277-7477-43b6-ad71-6a2d45a124d7

Owner

rickard2 commented May 20, 2013

Code and tests complete. Needs code documentation and new user documentation for shortcode / theme integration

Should also be put through some user testing :P

@ghost ghost assigned rickard2 May 20, 2013

Owner

rickard2 commented May 21, 2013

Check scrutinizer if complexity/mess was reduced by refactoring

Owner

rickard2 commented May 30, 2013

There are now no problems with complexity or mess in the Config class, the only issue from scrutinizer is that IntegerType and MeasurementType shares a couple of lines which is flagged as copy/paste.

@rickard2 rickard2 closed this May 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment