Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and add mocha tests #2

Merged
merged 2 commits into from Sep 11, 2014
Merged

Update documentation and add mocha tests #2

merged 2 commits into from Sep 11, 2014

Conversation

tandrewnichols
Copy link
Collaborator

Updates the documentation to include async usage. Adds mocha for testing.

I went bare-bones on the testing, but I can add a lot more if you have (for example) a travis account and/or a codeclimate account (both are free incidentally).

Any chance you can publish these changes on npm as a new version?

@rickbergfalk
Copy link
Owner

Thanks again! I'll publish to npm shortly.

I wouldn't mind hooking this up to travis but I haven't gotten to what that involves yet. So far I've just signed in with my github account at travis-ci.org

rickbergfalk added a commit that referenced this pull request Sep 11, 2014
Update documentation and add mocha tests
@rickbergfalk rickbergfalk merged commit 236abed into rickbergfalk:master Sep 11, 2014
@rickbergfalk
Copy link
Owner

Update has been published to npm under version 1.0.0! I also went ahead and added you as a collaborator in the package.json.

Would it be okay if I just went ahead and added you to the git repository as well?

@tandrewnichols
Copy link
Collaborator Author

Sure. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants