Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Aug 5, 2012
  1. Removed the assumption that the NSURLResponse we get back is a

    authored
    NSHTTPURLResponse, since in some cases it might not be. Such as if we're
    using a local (within-app) authentication url based on NSURLProtocol.
Commits on Jun 21, 2012
  1. @lukeredpath

    Build up a list of bindings to remove, then remove them, to avoid

    lukeredpath authored
    modifications to the nested arrays while they are being iterated over.
Commits on Jun 11, 2012
  1. @lukeredpath

    Improve the errors returned by channel authorisation, especially for

    lukeredpath authored
    non-dictionary and non-valid JSON responses.
    
    Also need to make sure we set isAuthorized back to NO if there is an
    error.
  2. @lukeredpath

    Don't wrap authorisation errors as the are already wrapped in a domain

    lukeredpath authored
    specific error, just create an unknown error if we aren't authorised
    and don't have an error.
  3. @lukeredpath
  4. @lukeredpath
Commits on Jun 7, 2012
  1. @lukeredpath

    Replace the client event buffer with an operation queue that is suspe…

    lukeredpath authored
    …nded
    
    while the channel is unsubscribed.
  2. @lukeredpath
  3. @lukeredpath
  4. @lukeredpath

    Wait for the test helper delegate to indicate we are no longer connected

    lukeredpath authored
    before continuing to the next spec.
    
    Also unsubscribe when we are done.
  5. @lukeredpath
  6. @lukeredpath

    Fixed pragma doc.

    lukeredpath authored
  7. @lukeredpath

    Switch channel internal bindings to use block-based callbacks.

    lukeredpath authored
    The previous target/action bindings were causing a retain cycle between
    the binding (target/action proxy) and the channel.
    
    By using blocks with weak references to the channel, the blocks act as
    weak proxies to the channel, and the retain cycle is broken.
Commits on Jun 4, 2012
  1. @lukeredpath
  2. @lukeredpath

    Revert "Cache channel authentication data."

    lukeredpath authored
    This reverts commit 1b92f78.
  3. @lukeredpath

    Cache channel authentication data.

    lukeredpath authored
    This avoids the need to make another authorisation request when reconnecting
    to an existing channel.
Commits on May 29, 2012
  1. @lukeredpath

    Because auto-reconnect happens after a delay, we should check that

    lukeredpath authored
    auto reconnect hasn't been disabled in the meantime before actually
    proceeding with the connection.
  2. @lukeredpath
  3. @lukeredpath

    Cancel all outstanding auth operations if the connection is closed.

    lukeredpath authored
    All auth requests are specific to a connection as they use the socket
    ID returned from Pusher - once that socket ID has gone away, the auth
    operations can never be successful.
  4. @lukeredpath
  5. @lukeredpath

    Add proper cancellation support to channel auth operations.

    lukeredpath authored
    If we want to cancel an auth operation, even if that request has 
    completed, we do not want to notify the delegate - we should just 
    ignore the response.
    
    We should also check for cancellation right at the start of the
    operation before running the URL request.
  6. @lukeredpath
Commits on May 24, 2012
  1. @lukeredpath
Commits on May 17, 2012
  1. @lukeredpath

    Ensure we don't try and subscribe to private channels when disconnected.

    lukeredpath authored
    We already check that we are connected before beginning the subscription
    process, but where that process is asynchronous and non-immediate, in
    the case of private/presence channels (because we have to run the
    authorisation operation first), we should check that we are still 
    connected again before finalising the subscription process.
  2. @lukeredpath
  3. @lukeredpath
  4. @lukeredpath
  5. @lukeredpath

    Wait until the handshake is received before notifying the client dele…

    lukeredpath authored
    …gate
    
    that the connection is open.
    
    Track this internally using an enum to track state rather than a simple
    boolean flag.
    
    This reverts old the old behaviour where the socketID would be available
    within the didConnect delegate call.
    
    See #47.
  6. @lukeredpath

    Allow calls to [channel unsubscribe] when disconnected without crashing.

    lukeredpath authored
    Normally, we would always attempt to send an unsubscribe message but
    if we are disconnected, this will cause an assertion error.
    
    Because we always mark channels as unsubscribed when the connection 
    closes, it isn't necessary to send an unsubscribe message in this state.
    
    Instead of attempting to send the unsubscribe (which causes the assertion
    error), simply return without doing anything.
    
    Closes #46.
Commits on May 15, 2012
  1. @lukeredpath
  2. @lukeredpath

    Make sure we always handle socket connection failures like any other

    lukeredpath authored
    type of disconnection.
    
    When SocketRocket's connection fails, we won't always receive the
    'didDisconnect' connection delegate method - sometimes we will receive
    the 'didFail' method.
    
    If we get the 'didFail' method, we'll pass that on to the Pusher delegate
    whether we were already connected or not.
    
    If we were already connected, then now it will also call the 'didDisconnect'
    delegate method.
    
    I've updated the connection monitor sample to account for this new behaviour.
    
    This should also fix #48.
Commits on May 11, 2012
  1. @lukeredpath

    Make header public

    lukeredpath authored
  2. @lukeredpath
  3. @lukeredpath

    Delegating to the same socket delegate methods that would be called

    lukeredpath authored
    using a real socket means that the mock connection behaves more like
    a real connection, including calling its own delegate.
  4. @lukeredpath

    Introduce a mock connection object that can be used to make testing of

    lukeredpath authored
    PTPusher much easier for end users.
Something went wrong with that request. Please try again.