New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default settings to be in one place and allow for usage in external app/addon #90

Merged
merged 1 commit into from Jan 23, 2016

Conversation

Projects
None yet
3 participants
@juwara0
Contributor

juwara0 commented Jan 21, 2016

Created a default-options file and moved the default settings to this file
Updated usage of default values in other files to require() the defaults from the default-options file
Added a section in the READme to let people know that the defaults can be accessed in their application or addon if needed.

Review on Reviewable

moved default settings to live together in a single file, updated fil…
…es to use in defaults file and added a mention in the READme
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 21, 2016

Current coverage is 95.39%

Merging #90 into master will increase coverage by +0.06% as of cc1adb7

@@            master     #90   diff @@
======================================
  Files            2       3     +1
  Stmts          150     152     +2
  Branches        36      36       
  Methods          0       0       
======================================
+ Hit            143     145     +2
  Partial          2       2       
  Missed           5       5       

Review entire Coverage Diff as of cc1adb7

Powered by Codecov. Updated on successful CI builds.

codecov-io commented Jan 21, 2016

Current coverage is 95.39%

Merging #90 into master will increase coverage by +0.06% as of cc1adb7

@@            master     #90   diff @@
======================================
  Files            2       3     +1
  Stmts          150     152     +2
  Branches        36      36       
  Methods          0       0       
======================================
+ Hit            143     145     +2
  Partial          2       2       
  Missed           5       5       

Review entire Coverage Diff as of cc1adb7

Powered by Codecov. Updated on successful CI builds.

@rickharrison

This comment has been minimized.

Show comment
Hide comment
@rickharrison

rickharrison Jan 23, 2016

Owner

Thanks for the contribution!

Owner

rickharrison commented Jan 23, 2016

Thanks for the contribution!

rickharrison added a commit that referenced this pull request Jan 23, 2016

Merge pull request #90 from juwara0/exportDefaultOptions
Updated default settings to be in one place and allow for usage in external app/addon

@rickharrison rickharrison merged commit c1a6a03 into rickharrison:master Jan 23, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment