allow the passing of an array of field names #64

Merged
merged 1 commit into from Jun 2, 2013

Projects

None yet

2 participants

Contributor
samccone commented Apr 9, 2013

like this

var validator = new FormValidator('foo', [{
name: ['zap', 'tap'],
display: 'required',
rules: 'required'
}

super super handy

Owner

This breaks the existing functionality.

Contributor

@rickharrison i was testing it and it seemed fine, is there a specific breakage?

Owner

Your code now requires the names to be submitted as an array. It does not work when using the old method.

Contributor

oh frick, crap that is a dumb mistake I will update this for you

Contributor

alright fixed the issue :)

sorry bout that

we should also look into adding some automated tests for this...

@rickharrison rickharrison merged commit 4172767 into rickharrison:master Jun 2, 2013
Owner

I just merged this in. I modified it that if you are passing in an array it must be as a "names" key and not a "name" key.

@samccone samccone deleted the samccone:sjs/allow-multiple-values branch Jun 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment