Rick Harrison rickharrison

Developer Program Member

Organizations

@meadow
@rickharrison

I need to look at all the contributions around this. I would like to reconcile all the different types of asset maps. I would like to decouple this…

rickharrison commented on pull request rackt/react-router#1158
@rickharrison

@ryanflorence As someone who has upgraded with every version, having some backwards compatibility functions would be super helpful and much appreci…

@rickharrison

I think this could be fixed by doing something like if (this.hasOwnProperty('customHash'). Would you mind testing it out and submitting a PR?

rickharrison commented on pull request rackt/react-router#1158
@rickharrison

In regards to the transition changes, will it be possible to define onChange on a component? Similar to how React now couples the markup with logic…

@rickharrison

Thanks for reporting this. Just to be upfront, this might be a difficult problem to solve. I don't really have an ETA at this time of when I will b…

@rickharrison

In development, I had a SyntaxError in one of my render functions. What happened was that the error was being swallowed by the .then(callback). If …

@rickharrison

Seems so janky, but also will fix the issue. Thanks for the tip. This is why some days I just really don't like promises haha.

@rickharrison

Yea, I am using es6-promise so that explains why nothing was happening. There has to be some way to surface the error without every single error in r…

@rickharrison

I tried this, and nothing appeared in the console: .catch(function (err) { SignIn.attemptedTransition = transition; transition.redirect('sign-in');…

@rickharrison

@gaearon I just realized that this ends up swallowing any errors that I have in my render methods of components that use this mixin. Do you have an…

@rickharrison
Missing "generateAssetMap" in the documentation
@rickharrison
@rickharrison
Updated description to have the generateAssetMap option
1 commit with 9 additions and 0 deletions
@rickharrison

Thanks!

@rickharrison

It is not currently a built in feature. You would need to look at the errors in the callback and display them in the right spot using any dom manip…

@rickharrison

Yea, I would definitely like to support something like this, most likely using a data-* attribute.

@rickharrison

A constructive pull request would be appreciated.

@rickharrison

Could you give an example of what you were doing and how it was affecting your expected output? Ideally, you should be able to modify the flash obj…

@rickharrison

A pull request would be much appreciated in this area :)

@rickharrison
  • @rickharrison 14bc62b
    Updates personal information.
@rickharrison

Hmmm without having some sort of reproducible case, I'm not really sure where to go from here.