Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to NUnit 3 #142

Merged
merged 6 commits into from Apr 16, 2017
Merged

Update to NUnit 3 #142

merged 6 commits into from Apr 16, 2017

Conversation

Nothing4You
Copy link
Contributor

No description provided.

@Nothing4You
Copy link
Contributor Author

I'll fix the travis issue after lunch - probably just needs a different command in .travis.yml. Tests are passing locally.

@Nothing4You
Copy link
Contributor Author

Tests are passing now, travis script needed some modification

@rickyah rickyah added this to the v3.0.0 milestone Apr 15, 2017
@rickyah
Copy link
Owner

rickyah commented Apr 15, 2017 •
edited

Thanks @Nothing4You

However as I don't know if version 3 of nunit is compatible with .net 2.0, and I don't want to break that, I'll merge this PR into the v3.0 development branch, where I'll be happy to break compatibility with older versions of the framework and adopt newer APIs.

@rickyah rickyah changed the base branch from development to v3.0/develop April 15, 2017 22:59
@rickyah
Copy link
Owner

rickyah commented Apr 15, 2017

@Nothing4You have you tried running the test locally
using runner from xamarin studio/visual studio for mac breaks a lot of tests, apparently the runner does not correctly uses the solution folder as root, so test that read/write files fail. Any input on this?

@rickyah
Fix typo, chang obsolete APIs
53d5ef2
@rickyah
Update DefaultIniDataConfigurationTests.cs
7fce175
@rickyah
Fix test running both locally and on travis
c165521
@rickyah
Merge branch 'update-nunit3' of git://github.com/Nothing4You/ini-pars…
5174f27 
…er into Nothing4You-update-nunit3

* 'update-nunit3' of git://github.com/Nothing4You/ini-parser:
  Update DefaultIniDataConfigurationTests.cs
@rickyah
Copy link
Owner

rickyah commented Apr 16, 2017

Ok, fixed the problem, NUnit3 does not changes the working folder for the tests anymore nunit/nunit#1072

@rickyah rickyah merged commit b080607 into rickyah:v3.0/develop Apr 16, 2017
@Nothing4You
Copy link
Contributor Author

Regarding the directory changing, that's why I added the cd to the travis tests. Visual Studio 2017 didn't have any issues with that for me.
NUnit 3 should be compatible with .net 2.0, I don't see how it could otherwise be used as a dependency in a .net 2.0 project?
packages.config contains that aswell

+  <package id="NUnit" version="3.6.1" targetFramework="net20" />
+  <package id="NUnit.ConsoleRunner" version="3.6.1" targetFramework="net20" />

And https://www.nuget.org/packages/NUnit/ lists NET 2.0+ as supported platform.

@Nothing4You Nothing4You deleted the update-nunit3 branch April 16, 2017 01:04
@Nothing4You Nothing4You restored the update-nunit3 branch April 16, 2017 01:05
@Nothing4You
Copy link
Contributor Author

Nothing4You commented Apr 16, 2017 •
edited

btw it'd be nice if this could get merged to the main dev branch as this is one of the dependencies for #122 (which you should reopen). from what i have learned so far it should even be possible to keep .net 2.0 support while also supporting .net standard 1.6 with some hacks

@Nothing4You Nothing4You deleted the update-nunit3 branch April 16, 2017 18:51
@rickyah rickyah added this to Planning in version 3.0 Apr 16, 2017
@rickyah rickyah moved this from Planning to Done in version 3.0 Apr 16, 2017
rickyah pushed a commit that referenced this pull request Apr 8, 2018
@Nothing4You @rickyah
Update to NUnit 3 (#142)
5714a8e 
* Update to NUnit 3

* Change obsolete APIs
* Fix test running both locally and on travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
version 3.0
  
Done
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nothing4You @rickyah