Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to specify semantic version category #532

Merged
merged 67 commits into from Sep 17, 2020
Merged

feat: add option to specify semantic version category #532

merged 67 commits into from Sep 17, 2020

Conversation

dunyakirkali
Copy link
Contributor

@dunyakirkali dunyakirkali commented Sep 10, 2020 •
edited

This Pull Request fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added if needed.
  • Does not affect documentation or it has been added or updated.

Resolves #459

@dunyakirkali dunyakirkali self-assigned this Sep 10, 2020
@dunyakirkali dunyakirkali added the enhancement New feature or request label Sep 10, 2020
@dunyakirkali dunyakirkali linked an issue Sep 10, 2020 that may be closed by this pull request
Filter PR to auto merge with semantic version #459
Closed
@coveralls
Copy link

coveralls commented Sep 10, 2020 •
edited

Pull Request Test Coverage Report for Build 259068362

  • 39 of 40 (97.5%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 96.503%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/eventHandlers/pullRequest/index.ts 8 9 88.89%
Totals Coverage Status
Change from base Build 257556123: 0.04%
Covered Lines: 185
Relevant Lines: 190
💛 - Coveralls

@dunyakirkali dunyakirkali changed the title Feat/add option to specify semantic version category feat: add option to specify semantic version category Sep 14, 2020
vdvleon
vdvleon suggested changes Sep 14, 2020
View reviewed changes
Copy link

@vdvleon vdvleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, but I gave some (linting related) comments.

src/eventHandlers/pullRequest/index.ts Outdated Show resolved Hide resolved
src/eventHandlers/pullRequest/index.ts Outdated Show resolved Hide resolved
src/eventHandlers/pullRequest/index.ts Show resolved Hide resolved
src/utilities/inputParsers.spec.ts Outdated Show resolved Hide resolved
src/utilities/inputParsers.ts Outdated Show resolved Hide resolved
src/utilities/prTitleParser.spec.ts Outdated Show resolved Hide resolved
src/utilities/prTitleParser.spec.ts Outdated Show resolved Hide resolved
src/utilities/prTitleParser.ts Outdated Show resolved Hide resolved
src/utilities/prTitleParser.ts Outdated Show resolved Hide resolved
merlinnot
merlinnot reviewed Sep 16, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@merlinnot merlinnot removed their request for review September 16, 2020 08:47
merlinnot
merlinnot reviewed Sep 16, 2020
View reviewed changes
Copy link
Contributor

@merlinnot merlinnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation look good overall 🙂 We might need to adjust it depending on how we resolve some comments about the documentation I added.

.tool-versions Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/utilities/prTitleParsers.ts Show resolved Hide resolved
src/utilities/prTitleParsers.ts Show resolved Hide resolved
merlinnot
merlinnot reviewed Sep 17, 2020
View reviewed changes
src/eventHandlers/pullRequest/index.spec.ts Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/utilities/inputParsers.ts Outdated Show resolved Hide resolved
src/eventHandlers/pullRequest/majorBump.spec.ts Outdated Show resolved Hide resolved
merlinnot
merlinnot approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@merlinnot merlinnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it! 🎉

action.yml Outdated Show resolved Hide resolved
@dunyakirkali @merlinnot
chore: update action.yml
2ecfddf 
Co-authored-by: Natan Sągol <m@merlinnot.com>
@dunyakirkali dunyakirkali merged commit fedba96 into master Sep 17, 2020
@dunyakirkali dunyakirkali deleted the feat/add_option_to_specify_semantic_version_category branch September 17, 2020 09:27
jraoult
jraoult reviewed Sep 17, 2020
View reviewed changes
README.md
- `DEPENDABOT_MINOR` - Merge only minor and patch dependency updates for pull
requests created by Dependabot if the dependency version follows
[Semantic Versioning v2](https://semver.org/).
- `DEPENDABOT_PATH` - Merge only patch dependency updates for pull requests
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry a little late to the party, but surely here it was supposed to be PATCH

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out @jraoult. I opened a PR for it #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrSchild JrSchild JrSchild left review comments

@jraoult jraoult jraoult left review comments

@vdvleon vdvleon vdvleon approved these changes

@merlinnot merlinnot merlinnot approved these changes

@viestat viestat Awaiting requested review from viestat

Assignees

@dunyakirkali dunyakirkali

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter PR to auto merge with semantic version
6 participants
@dunyakirkali @coveralls @merlinnot @JrSchild @vdvleon @jraoult