Sprintlet... #61

Closed
wants to merge 5 commits into
from

3 participants

@roalddevries

For as far as the metadata is concerned: if no schema is supplied in the settings, no metadata can be entered in the admin, and it would be nicer to hide the metadata-fieldset altogether. Good luck ;-)!

@mvdwaeter

Hi Roald,

is it possible to merge the Fiber commits of Feb 16, 2012 into your fork?
That way, I can easily review your code

@dbunskoek dbunskoek added a commit that referenced this pull request Feb 24, 2012
@dbunskoek dbunskoek fixes PT #23214363 - "dropped content always shows up on the bottom o…
…f the content area, it should show up on the spot where it was dropped."

- delivered in pull request #61, thanks @roalddevries
72b56f9
@dbunskoek
Ride The Pony member

The fix for Pivotal Tracker bug #23214363 (your commit 4dc703e) was added in commit 72b56f9, thanks!

@dbunskoek dbunskoek closed this Feb 24, 2012
@dbunskoek dbunskoek reopened this Feb 24, 2012
@dbunskoek
Ride The Pony member

I just integrated your (slightly tweaked) metadata changes, thanks!
It works nicely, but it could still use a little love (as you already mentioned) regarding the handling of null / default values.
I also see a remaining {} when I remove previously added metadata, I don't think it should do that?

@dbunskoek dbunskoek closed this Apr 2, 2012
@dbunskoek
Ride The Pony member

I'm not so sure about the page url validation, I think we'll have to revisit it later. I'm closing the pull request for now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment