Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/move class from php core #21

Merged
merged 9 commits into from Sep 6, 2019

Conversation

@Goliathtom
Copy link
Contributor

commented May 28, 2019

php-core 로부터의 코드 이관 중
ReplicationStatus 와 slaveServer 관련 입니다.

코드 + platform-common 에 ConnectionGroup 이 들어가는게 맞는 것인가 에 대한 리뷰 요청 드립니다.

문정기 added 3 commits May 24, 2019

@Goliathtom Goliathtom requested a review from ssaifriend May 28, 2019

@Goliathtom

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

여기에 ConnectionGroup 이 있는게 올바르지 않다고 생각되어,

  1. ConnectionGroup을 platform-const 로 옮긴다.
  2. 프로젝트 내 사용처는 Book-api 뿐이기 때문에, Book API 내 하드코딩 한다.

두가지 옵션이 있는거 같습니다

@ssaifriend
Copy link
Member

left a comment

ConnectionGroupPlatformConnectionGroup 으로 통합하고 현재 사용중인 상수만 옮겨주세요.

@Goliathtom Goliathtom merged commit 0ff12ec into master Sep 6, 2019

@Goliathtom Goliathtom deleted the feature/move_class_from_php_core branch Sep 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.