Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Default event hostname #20

Merged
merged 1 commit into from Feb 7, 2013

Conversation

Projects
None yet
2 participants
Contributor

timshadel commented Feb 6, 2013

Useful when trying riemann-health on a box to which you don't have access to change the hostname—like Heroku where hostname returns a GUID that's meaningless to you.

Contributor

timshadel commented Feb 7, 2013

I totally agree that the distinction's hard to make; the only problem I have with event-host is that it doesn't seem to like that as a symbol in Ruby.

opt :event-host, "Event hostname", :type => String

Other preferences? Plain :name? :eventhost? I'm open to anything, really. Tell me what you'd like and I'll make the change. :-)

Allow the event host to be set on the command line
Useful when trying `riemann-health` on a box to which you don't
have access to change the hostname—like Heroku where `hostname`
returns a GUID that's meaningless to you.
Contributor

timshadel commented Feb 7, 2013

Odd; force-pushing to my fork seemed to nuke your comments from this PR. Fantastic tip about Trollup allowing --event-host to map to :event_host. Changes made and rebased on your recent merge. :-)

Collaborator

aphyr commented Feb 7, 2013

Thanks so much Tim! I've added you to the contributors file. 👍

aphyr added a commit that referenced this pull request Feb 7, 2013

@aphyr aphyr merged commit 7de2572 into riemann:master Feb 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment