Percentiles in Graphite assume two digits of precision #16

Closed
chawco opened this Issue Jun 18, 2012 · 0 comments

Projects

None yet

2 participants

@chawco
chawco commented Jun 18, 2012

Hi, I was recently trying to create a 99.9th percentile graph in Graphite, but couldn't figure out for the life of me where the data was going. I could see the events being emitted in the stream, and everything looked fine. Finally figured out the offending bit is this:

https://github.com/aphyr/riemann/blob/master/src/riemann/graphite.clj#L21

Seems that it's assuming two digits of precision for percentiles at all times. I'm mulling over some options for dealing with this, without breaking existing deployments.

@aphyr aphyr added a commit that closed this issue Jan 25, 2013
@aphyr aphyr graphite-path-percentiles will convert longer decimals to percentiles.
This is such an awful hack. Riemann will now convert services like "api
reqs/sec 0.999" to "api reqs/sec 999". If you need to talk about things
other than percentiles, this will screw you up; use graphite-path
instead. Closes #16. I'm so sorry.
a760d1f
@aphyr aphyr closed this in a760d1f Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment