Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

rollup stops when an expired event arrives #19

Closed
lwf opened this Issue Aug 24, 2012 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

lwf commented Aug 24, 2012

The rollup stream primitive uses periodically-until-expired (by use of part-time-fast), which stops when an expired event occurs. This is sensible for some use cases but creates problems in others, for instance when trying to roll up all expired events per host.

Maybe part-time-fast could be refactored to provide a parameter as to whether periodic/every or periodically-until-expired should be used?

Collaborator

aphyr commented Aug 24, 2012

On 08/24/2012 07:17 AM, Torbjörn Norinder wrote:

The rollup stream primitive uses periodically-until-expired (by use of
part-time-fast), which stops when an expired event occurs. This is
sensible for some use cases but creates problems in others, for instance
when trying to roll up all expired events per host.

Maybe part-time-fast could be refactored to provide a parameter as to
whether periodic/every or periodically-until-expired should be used?


Reply to this email directly or view it on GitHub
aphyr#19.

I think you're absolutely right. I'll add a ticket for myself.

--Kyle

@aphyr aphyr closed this Jan 26, 2013

aphyr added a commit that referenced this issue Jan 26, 2013

streams/rollup no longer leaks tasks, handles expired events
Complete rewrite of (rollup). Rollup takes advantage of the new
riemann.time scheduler to schedule ticks on its own, and since it
doesn't use recurrent tasks, won't leak tasks if improperly shut down or
waste resources when inactive. Rollup now correctly aggregates expired
events and forwards them as expected, instead of shutting down when an
expired event arrives.

Closes #19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment